net/mlx5e: check return value of rhashtable_init

When rhashtable_init() fails, it returns -EINVAL.
However, since error return value of rhashtable_init is not checked,
it can cause use of uninitialized pointers.
So, fix unhandled errors of rhashtable_init.

Signed-off-by: MichelleJin <shjy180909@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
index 6c949abcd2e140465d1981d67ea8d232cc8da583..225748a9e52a715b735eb1062a032e6119b58962 100644 (file)
--- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
@@ -2127,12 +2127,20 @@ mlx5_tc_ct_init(struct mlx5e_priv *priv, struct mlx5_fs_chains *chains,
 
        ct_priv->post_act = post_act;
        mutex_init(&ct_priv->control_lock);
-       rhashtable_init(&ct_priv->zone_ht, &zone_params);
-       rhashtable_init(&ct_priv->ct_tuples_ht, &tuples_ht_params);
-       rhashtable_init(&ct_priv->ct_tuples_nat_ht, &tuples_nat_ht_params);
+       if (rhashtable_init(&ct_priv->zone_ht, &zone_params))
+               goto err_ct_zone_ht;
+       if (rhashtable_init(&ct_priv->ct_tuples_ht, &tuples_ht_params))
+               goto err_ct_tuples_ht;
+       if (rhashtable_init(&ct_priv->ct_tuples_nat_ht, &tuples_nat_ht_params))
+               goto err_ct_tuples_nat_ht;
 
        return ct_priv;
 
+err_ct_tuples_nat_ht:
+       rhashtable_destroy(&ct_priv->ct_tuples_ht);
+err_ct_tuples_ht:
+       rhashtable_destroy(&ct_priv->zone_ht);
+err_ct_zone_ht:
 err_ct_nat_tbl:
        mlx5_chains_destroy_global_table(chains, ct_priv->ct);
 err_ct_tbl: