]> www.infradead.org Git - users/willy/pagecache.git/commitdiff
net/mlx5: Fill out devlink dev info only for PFs
authorJiri Pirko <jiri@nvidia.com>
Thu, 6 Mar 2025 21:25:29 +0000 (23:25 +0200)
committerJakub Kicinski <kuba@kernel.org>
Sat, 8 Mar 2025 03:33:00 +0000 (19:33 -0800)
Firmware version query is supported on the PFs. Due to this
following kernel warning log is observed:

[  188.590344] mlx5_core 0000:08:00.2: mlx5_fw_version_query:816:(pid 1453): fw query isn't supported by the FW

Fix it by restricting the query and devlink info to the PF.

Fixes: 8338d9378895 ("net/mlx5: Added devlink info callback")
Signed-off-by: Jiri Pirko <jiri@nvidia.com>
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Reviewed-by: Parav Pandit <parav@nvidia.com>
Link: https://patch.msgid.link/20250306212529.429329-1-tariqt@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/devlink.c

index 98d4306929f3edf3782d573b5f207a04d64fecdb..a2cf3e79693dd8060c5c5d1b42ef1e4349d8058b 100644 (file)
@@ -46,6 +46,9 @@ mlx5_devlink_info_get(struct devlink *devlink, struct devlink_info_req *req,
        u32 running_fw, stored_fw;
        int err;
 
+       if (!mlx5_core_is_pf(dev))
+               return 0;
+
        err = devlink_info_version_fixed_put(req, "fw.psid", dev->board_id);
        if (err)
                return err;