]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
ksmbd: fix malformed unsupported smb1 negotiate response
authorNamjae Jeon <linkinjeon@kernel.org>
Tue, 12 Nov 2024 23:49:44 +0000 (08:49 +0900)
committerSteve French <stfrench@microsoft.com>
Sun, 17 Nov 2024 22:29:09 +0000 (16:29 -0600)
When mounting with vers=1.0, ksmbd should return unsupported smb1
negotiate response. But this response is malformed.

[ 6010.586702] CIFS: VFS: Bad protocol string signature header 0x25000000
[ 6010.586708] 0000000025000000 25000000 424d53ff 00000072  ...%...%.SMBr...
[ 6010.586711] 00000010c8408000 00000000 00000000 00000000  ..@.............
[ 6010.586713] 00000020: 00 00 b9 32 00 00 01 00 01                  ...2.....

Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/server/smb_common.c

index 75b4eb856d32f7ddc856ad5cf04906638cede0b5..c3e4e0e9549289541b73bddbb1962d483d00ad56 100644 (file)
@@ -576,7 +576,7 @@ static int smb_handle_negotiate(struct ksmbd_work *work)
 
        ksmbd_debug(SMB, "Unsupported SMB1 protocol\n");
 
-       if (ksmbd_iov_pin_rsp(work, (void *)neg_rsp,
+       if (ksmbd_iov_pin_rsp(work, (void *)neg_rsp + 4,
                              sizeof(struct smb_negotiate_rsp) - 4))
                return -ENOMEM;