]> www.infradead.org Git - users/dwmw2/qemu.git/commitdiff
scsi-disk: return CHECK CONDITION for unknown page codes in the MODE SENSE command
authorBernhard Kohl <bernhard.kohl@nsn.com>
Tue, 31 Aug 2010 12:08:26 +0000 (14:08 +0200)
committerKevin Wolf <kwolf@redhat.com>
Mon, 13 Sep 2010 12:31:37 +0000 (14:31 +0200)
SCSI-Spec:
http://ldkelley.com/SCSI2/SCSI2/SCSI2-08.html#8.2.10
"An initiator may request any one or all of the supported mode pages
from a target. If an initiator issues a MODE SENSE command with a
page code value not implemented by the target, the target shall return
CHECK CONDITION status and shall set the sense key to ILLEGAL REQUEST
and the additional sense code to INVALID FIELD IN CDB."

Signed-off-by: Bernhard Kohl <bernhard.kohl@nsn.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
(cherry picked from commit a9c17b2bf3639662fbdeb736289ebabfda9fa21a)

hw/scsi-disk.c

index 2a107b1bfda82905f881f848043bd2f4dddfa7c2..70c7a08190caeed9cbbdfcaf583835fab0e8a2d5 100644 (file)
@@ -689,6 +689,8 @@ static int scsi_disk_emulate_mode_sense(SCSIRequest *req, uint8_t *outbuf)
         p += mode_sense_page(req, 0x08, p, page_control);
         p += mode_sense_page(req, 0x2a, p, page_control);
         break;
+    default:
+        return -1; /* ILLEGAL_REQUEST */
     }
 
     buflen = p - outbuf;