]> www.infradead.org Git - users/willy/xarray.git/commitdiff
net: mvpp2: fix memory leak in mvpp2_rx
authorLorenzo Bianconi <lorenzo@kernel.org>
Fri, 31 Jul 2020 08:38:32 +0000 (10:38 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 3 Aug 2020 22:14:46 +0000 (15:14 -0700)
Release skb memory in mvpp2_rx() if mvpp2_rx_refill routine fails

Fixes: b5015854674b ("net: mvpp2: fix refilling BM pools in RX path")
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Acked-by: Matteo Croce <mcroce@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c

index 6a3f356640a0783cad998a9522f466dd3e9643fe..4298a029be5546d3996d384bdbb2f2fa1ffc72ad 100644 (file)
@@ -3508,6 +3508,7 @@ static int mvpp2_rx(struct mvpp2_port *port, struct napi_struct *napi,
                err = mvpp2_rx_refill(port, bm_pool, pp, pool);
                if (err) {
                        netdev_err(port->dev, "failed to refill BM pools\n");
+                       dev_kfree_skb_any(skb);
                        goto err_drop_frame;
                }