gpio: sim: switch to device_for_each_child_node_scoped()

Switch to device_for_each_child_node_scoped() to simplify the code by
removing the need for a call to fwnode_handle_put() in the error path.

This also prevents possible memory leaks if new error paths are added
without the required call to fwnode_handle_put().

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20240928-gpio_device_for_each_child_node_scoped-v1-2-c20eff315f4f@gmail.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
index dcca1d7f173e5f186219aa2897dfc0be50a3d2b2..f387dad81f2960b5ec3c1b5fd04081ee501cc75b 100644 (file)
--- a/drivers/gpio/gpio-sim.c
+++ b/drivers/gpio/gpio-sim.c
@@ -520,15 +520,12 @@ static int gpio_sim_add_bank(struct fwnode_handle *swnode, struct device *dev)
 static int gpio_sim_probe(struct platform_device *pdev)
 {
        struct device *dev = &pdev->dev;
-       struct fwnode_handle *swnode;
        int ret;
 
-       device_for_each_child_node(dev, swnode) {
+       device_for_each_child_node_scoped(dev, swnode) {
                ret = gpio_sim_add_bank(swnode, dev);
-               if (ret) {
-                       fwnode_handle_put(swnode);
+               if (ret)
                        return ret;
-               }
        }
 
        return 0;