]> www.infradead.org Git - linux.git/commitdiff
jbd2: remove dead equality check of j_commit_[sequence/request] in kjournald2
authorKemeng Shi <shikemeng@huaweicloud.com>
Tue, 14 May 2024 11:24:36 +0000 (19:24 +0800)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 27 Jun 2024 14:20:26 +0000 (10:20 -0400)
The j_commit_[sequence/request] are updated with j_state_lock held during
runtime. In kjournald2, two equality checks of j_commit_[sequence/request]
are under the same j_state_lock, then the second check is unnecessary.

Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Reviewed-by: Zhang Yi <yi.zhang@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://patch.msgid.link/20240514112438.1269037-8-shikemeng@huaweicloud.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/jbd2/journal.c

index 1ea96ab9374a7fd8e1e68dcfe09388aa1b7907f8..079b3eeaa4d50517c4d515014487b42028eb7576 100644 (file)
@@ -224,8 +224,6 @@ loop:
 
                prepare_to_wait(&journal->j_wait_commit, &wait,
                                TASK_INTERRUPTIBLE);
-               if (journal->j_commit_sequence != journal->j_commit_request)
-                       should_sleep = 0;
                transaction = journal->j_running_transaction;
                if (transaction && time_after_eq(jiffies,
                                                transaction->t_expires))