fabrics: fix a check-after-dereference error in nvmf_discovery_log()

logp pointer can't be NULL, because it has already been dereferenced,
the function should check *logp instead.

Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>

diff --git a/src/nvme/fabrics.c b/src/nvme/fabrics.c
index a501f7900c5fa84311eae27406bdfc637c2c5384..f943090b28f18ee1ac1c6af3d0bebd8a0828106d 100644 (file)
--- a/src/nvme/fabrics.c
+++ b/src/nvme/fabrics.c
@@ -894,7 +894,7 @@ int nvmf_get_discovery_log(nvme_ctrl_t c, struct nvmf_discovery_log **logp,
                .ot = false,
        };
        *logp = nvme_discovery_log(c, &args, max_retries);
-       return logp ? 0 : -1;
+       return *logp ? 0 : -1;
 }
 
 struct nvmf_discovery_log *nvmf_get_discovery_wargs(struct nvme_get_discovery_args *args)