]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
x86/nmi: Remove the 'strange power saving mode' hint from unknown NMI handler
authorJiri Kosina <jkosina@suse.cz>
Mon, 14 Mar 2022 08:25:18 +0000 (09:25 +0100)
committerBorislav Petkov <bp@suse.de>
Wed, 16 Mar 2022 10:02:41 +0000 (11:02 +0100)
The

  Do you have a strange power saving mode enabled?

hint when unknown NMI happens dates back to i386 stone age, and isn't
currently really helpful.

Unknown NMIs are coming for many different reasons (broken firmware,
faulty hardware, ...) and rarely have anything to do with 'strange power
saving mode' (whatever that even is).

Just remove it as it's largerly misleading.

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Borislav Petkov <bp@suse.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/r/nycvar.YFH.7.76.2203140924120.24795@cbobk.fhfr.pm
arch/x86/kernel/nmi.c

index 4bce802d25fb18b79cd525883ea87a2b4a75ff24..e73f7df362f5d178b008dc8e15ff4eb6d4f7af5e 100644 (file)
@@ -292,7 +292,6 @@ unknown_nmi_error(unsigned char reason, struct pt_regs *regs)
        pr_emerg("Uhhuh. NMI received for unknown reason %02x on CPU %d.\n",
                 reason, smp_processor_id());
 
-       pr_emerg("Do you have a strange power saving mode enabled?\n");
        if (unknown_nmi_panic || panic_on_unrecovered_nmi)
                nmi_panic(regs, "NMI: Not continuing");