]> www.infradead.org Git - users/hch/misc.git/commitdiff
drm/amdgpu: Report generic instead of unknown boot time errors
authorXiang Liu <xiang.liu@amd.com>
Wed, 26 Feb 2025 06:27:27 +0000 (14:27 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 27 Feb 2025 21:50:03 +0000 (16:50 -0500)
Change the DMESG reporting of unknown errors to "Boot Controller
Generic Error" to align with the RAS SPEC and provide more clarity
to customers.

Signed-off-by: Xiang Liu <xiang.liu@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h

index 493dd004d6fa95e5916da3f7f9be950484ff971a..285e3aa2bb2f9cf03686aaff2d6c3882e82427b9 100644 (file)
@@ -5138,9 +5138,9 @@ static void amdgpu_ras_boot_time_error_reporting(struct amdgpu_device *adev,
                         "socket: %d, aid: %d, fw_status: 0x%x, data abort exception\n",
                         socket_id, aid_id, fw_status);
 
-       if (AMDGPU_RAS_GPU_ERR_UNKNOWN(boot_error))
+       if (AMDGPU_RAS_GPU_ERR_GENERIC(boot_error))
                dev_info(adev->dev,
-                        "socket: %d, aid: %d, fw_status: 0x%x, unknown boot time errors\n",
+                        "socket: %d, aid: %d, fw_status: 0x%x, Boot Controller Generic Error\n",
                         socket_id, aid_id, fw_status);
 }
 
index cc4586581dba93614caf37b503d4b0338907360b..764e9fa0a914af11a89c6863284952437cd6ed79 100644 (file)
@@ -47,7 +47,7 @@ struct amdgpu_iv_entry;
 #define AMDGPU_RAS_GPU_ERR_AID_ID(x)                   AMDGPU_GET_REG_FIELD(x, 12, 11)
 #define AMDGPU_RAS_GPU_ERR_HBM_ID(x)                   AMDGPU_GET_REG_FIELD(x, 14, 13)
 #define AMDGPU_RAS_GPU_ERR_DATA_ABORT(x)               AMDGPU_GET_REG_FIELD(x, 29, 29)
-#define AMDGPU_RAS_GPU_ERR_UNKNOWN(x)                  AMDGPU_GET_REG_FIELD(x, 30, 30)
+#define AMDGPU_RAS_GPU_ERR_GENERIC(x)                  AMDGPU_GET_REG_FIELD(x, 30, 30)
 
 #define AMDGPU_RAS_BOOT_STATUS_POLLING_LIMIT   100
 #define AMDGPU_RAS_BOOT_STEADY_STATUS          0xBA