]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
dm integrity: fix error code in dm_integrity_ctr()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 25 Apr 2022 11:56:48 +0000 (14:56 +0300)
committerMike Snitzer <snitzer@kernel.org>
Mon, 9 May 2022 16:14:00 +0000 (12:14 -0400)
The "r" variable shadows an earlier "r" that has function scope.  It
means that we accidentally return success instead of an error code.
Smatch has a warning for this:

drivers/md/dm-integrity.c:4503 dm_integrity_ctr()
warn: missing error code 'r'

Fixes: 7eada909bfd7 ("dm: add integrity target")
Cc: stable@vger.kernel.org
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
drivers/md/dm-integrity.c

index 36ae30b73a6e0eae654528741c964c6cb915a814..3d5a0ce123c905cf038e9412310e7e561b5fd080 100644 (file)
@@ -4494,8 +4494,6 @@ try_smaller_buffer:
        }
 
        if (should_write_sb) {
-               int r;
-
                init_journal(ic, 0, ic->journal_sections, 0);
                r = dm_integrity_failed(ic);
                if (unlikely(r)) {