]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
drm/amd/display: Refactor HPD IRQ error checking flow
authorLeon Huang <Leon.Huang1@amd.com>
Mon, 21 Oct 2024 09:22:35 +0000 (17:22 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 8 Nov 2024 16:45:29 +0000 (11:45 -0500)
[Why]
HPD error status does not cover Replay desync error status
while executing autotests and CTS tests.

[How]
Refactor the checking flow, reporting the HPD error based on
different eDP feature.

Reviewed-by: Robin Chen <robin.chen@amd.com>
Signed-off-by: Leon Huang <Leon.Huang1@amd.com>
Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_irq_handler.c

index 96bf135b6f05afea4dd44a393c2a651259db6363..48abeaa886780f28e0d4fdefebcb2cf18423c694 100644 (file)
@@ -221,21 +221,11 @@ static void handle_hpd_irq_replay_sink(struct dc_link *link)
                &replay_error_status.raw,
                sizeof(replay_error_status.raw));
 
-       link->replay_settings.config.replay_error_status.bits.LINK_CRC_ERROR =
-               replay_error_status.bits.LINK_CRC_ERROR;
-       link->replay_settings.config.replay_error_status.bits.DESYNC_ERROR =
-               replay_configuration.bits.DESYNC_ERROR_STATUS;
-       link->replay_settings.config.replay_error_status.bits.STATE_TRANSITION_ERROR =
-               replay_configuration.bits.STATE_TRANSITION_ERROR_STATUS;
-
-       if (link->replay_settings.config.replay_error_status.bits.LINK_CRC_ERROR ||
-               link->replay_settings.config.replay_error_status.bits.DESYNC_ERROR ||
-               link->replay_settings.config.replay_error_status.bits.STATE_TRANSITION_ERROR) {
+       if (replay_error_status.bits.LINK_CRC_ERROR ||
+               replay_configuration.bits.DESYNC_ERROR_STATUS ||
+               replay_configuration.bits.STATE_TRANSITION_ERROR_STATUS) {
                bool allow_active;
 
-               if (link->replay_settings.config.replay_error_status.bits.DESYNC_ERROR)
-                       link->replay_settings.config.received_desync_error_hpd = 1;
-
                if (link->replay_settings.config.force_disable_desync_error_check)
                        return;