netrom: Fix data-races around sysctl_net_busy_read

We need to protect the reader reading the sysctl value because the
value can be changed concurrently.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Jason Xing <kernelxing@tencent.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>

diff --git a/net/netrom/af_netrom.c b/net/netrom/af_netrom.c
index 1671be042ffef0152077662926e18e291132562c..104a80b75477f60199c69811ff48e65af293297c 100644 (file)
--- a/net/netrom/af_netrom.c
+++ b/net/netrom/af_netrom.c
@@ -954,7 +954,7 @@ int nr_rx_frame(struct sk_buff *skb, struct net_device *dev)
                 * G8PZT's Xrouter which is sending packets with command type 7
                 * as an extension of the protocol.
                 */
-               if (sysctl_netrom_reset_circuit &&
+               if (READ_ONCE(sysctl_netrom_reset_circuit) &&
                    (frametype != NR_RESET || flags != 0))
                        nr_transmit_reset(skb, 1);
 

diff --git a/net/netrom/nr_in.c b/net/netrom/nr_in.c
index 2f084b6f69d7e05b51d1673157e8e72f3b9e2635..97944db6b5ac64387d8c8d53dc551bb11f1789f1 100644 (file)
--- a/net/netrom/nr_in.c
+++ b/net/netrom/nr_in.c
@@ -97,7 +97,7 @@ static int nr_state1_machine(struct sock *sk, struct sk_buff *skb,
                break;
 
        case NR_RESET:
-               if (sysctl_netrom_reset_circuit)
+               if (READ_ONCE(sysctl_netrom_reset_circuit))
                        nr_disconnect(sk, ECONNRESET);
                break;
 
@@ -128,7 +128,7 @@ static int nr_state2_machine(struct sock *sk, struct sk_buff *skb,
                break;
 
        case NR_RESET:
-               if (sysctl_netrom_reset_circuit)
+               if (READ_ONCE(sysctl_netrom_reset_circuit))
                        nr_disconnect(sk, ECONNRESET);
                break;
 
@@ -262,7 +262,7 @@ static int nr_state3_machine(struct sock *sk, struct sk_buff *skb, int frametype
                break;
 
        case NR_RESET:
-               if (sysctl_netrom_reset_circuit)
+               if (READ_ONCE(sysctl_netrom_reset_circuit))
                        nr_disconnect(sk, ECONNRESET);
                break;