]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
selftests/net: Fix ./ns-XXXXXX not cleanup
authorLi Zhijian <lizhijian@fujitsu.com>
Wed, 30 Oct 2024 00:59:43 +0000 (08:59 +0800)
committerJakub Kicinski <kuba@kernel.org>
Fri, 1 Nov 2024 02:21:36 +0000 (19:21 -0700)
```
readonly STATS="$(mktemp -p /tmp ns-XXXXXX)"
readonly BASE=`basename $STATS`
```
It could be a mistake to write to $BASE rather than $STATS, where $STATS
is used to save the NSTAT_HISTORY and it will be cleaned up before exit.

Although since we've been creating the wrong file this whole time and
everything worked, it's fine to remove these 2 lines completely

Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
Link: https://patch.msgid.link/20241030005943.400225-1-lizhijian@fujitsu.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/veth.sh

index 4f1edbafb946871572c1e337b75aef8c045da3e7..6bb7dfaa30b6ae6ea3685ed481fbaaa111a9f41b 100755 (executable)
@@ -46,8 +46,6 @@ create_ns() {
                ip -n $BASE$ns addr add dev veth$ns $BM_NET_V4$ns/24
                ip -n $BASE$ns addr add dev veth$ns $BM_NET_V6$ns/64 nodad
        done
-       echo "#kernel" > $BASE
-       chmod go-rw $BASE
 }
 
 __chk_flag() {