]> www.infradead.org Git - users/hch/misc.git/commitdiff
eth: mlx4: select PAGE_POOL
authorGreg Thelen <gthelen@google.com>
Tue, 1 Apr 2025 01:53:15 +0000 (18:53 -0700)
committerJakub Kicinski <kuba@kernel.org>
Wed, 2 Apr 2025 23:25:31 +0000 (16:25 -0700)
With commit 8533b14b3d65 ("eth: mlx4: create a page pool for Rx") mlx4
started using functions guarded by PAGE_POOL. This change introduced
build errors when CONFIG_MLX4_EN is set but CONFIG_PAGE_POOL is not:

  ld: vmlinux.o: in function `mlx4_en_alloc_frags':
  en_rx.c:(.text+0xa5eaf9): undefined reference to `page_pool_alloc_pages'
  ld: vmlinux.o: in function `mlx4_en_create_rx_ring':
  (.text+0xa5ee91): undefined reference to `page_pool_create'

Make MLX4_EN select PAGE_POOL to fix the ml;x4 build errors.

Fixes: 8533b14b3d65 ("eth: mlx4: create a page pool for Rx")
Signed-off-by: Greg Thelen <gthelen@google.com>
Reviewed-by: Joe Damato <jdamato@fastly.com>
Link: https://patch.msgid.link/20250401015315.2306092-1-gthelen@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlx4/Kconfig

index 825e05fb86078607449c7427c5a67d53209108fa..0b1cb340206f3a0a89eea78e9296675ebd11b3a9 100644 (file)
@@ -7,6 +7,7 @@ config MLX4_EN
        tristate "Mellanox Technologies 1/10/40Gbit Ethernet support"
        depends on PCI && NETDEVICES && ETHERNET && INET
        depends on PTP_1588_CLOCK_OPTIONAL
+       select PAGE_POOL
        select MLX4_CORE
        help
          This driver supports Mellanox Technologies ConnectX Ethernet