ASoC: fsl_asrc: Add initialization finishing check in runtime resume

If the initialization is not finished, then filling input data to
the FIFO may fail. So it is better to add initialization finishing
check in the runtime resume for suspend & resume case.

And consider the case of three instances working in parallel,
increase the retry times to 50 for more initialization time.

Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
Reviewed-by: Nicolin Chen <nicolinc@gmail.com>
Link: https://lore.kernel.org/r/1662695098-24602-1-git-send-email-shengjiu.wang@nxp.com
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c
index aa5edf32d988955ba08178e1d96518b2e5406213..936aef5d2767c5a1d47a8b66758995b9da38c914 100644 (file)
--- a/sound/soc/fsl/fsl_asrc.c
+++ b/sound/soc/fsl/fsl_asrc.c
@@ -20,6 +20,7 @@
 
 #define IDEAL_RATIO_DECIMAL_DEPTH 26
 #define DIVIDER_NUM  64
+#define INIT_RETRY_NUM 50
 
 #define pair_err(fmt, ...) \
        dev_err(&asrc->pdev->dev, "Pair %c: " fmt, 'A' + index, ##__VA_ARGS__)
@@ -27,6 +28,9 @@
 #define pair_dbg(fmt, ...) \
        dev_dbg(&asrc->pdev->dev, "Pair %c: " fmt, 'A' + index, ##__VA_ARGS__)
 
+#define pair_warn(fmt, ...) \
+       dev_warn(&asrc->pdev->dev, "Pair %c: " fmt, 'A' + index, ##__VA_ARGS__)
+
 /* Corresponding to process_option */
 static unsigned int supported_asrc_rate[] = {
        5512, 8000, 11025, 12000, 16000, 22050, 24000, 32000, 44100, 48000,
@@ -579,7 +583,7 @@ static void fsl_asrc_start_pair(struct fsl_asrc_pair *pair)
 {
        struct fsl_asrc *asrc = pair->asrc;
        enum asrc_pair_index index = pair->index;
-       int reg, retry = 10, i;
+       int reg, retry = INIT_RETRY_NUM, i;
 
        /* Enable the current pair */
        regmap_update_bits(asrc->regmap, REG_ASRCTR,
@@ -592,6 +596,10 @@ static void fsl_asrc_start_pair(struct fsl_asrc_pair *pair)
                reg &= ASRCFG_INIRQi_MASK(index);
        } while (!reg && --retry);
 
+       /* NOTE: Doesn't treat initialization timeout as an error */
+       if (!retry)
+               pair_warn("initialization isn't finished\n");
+
        /* Make the input fifo to ASRC STALL level */
        regmap_read(asrc->regmap, REG_ASRCNCR, &reg);
        for (i = 0; i < pair->channels * 4; i++)
@@ -1257,6 +1265,7 @@ static int fsl_asrc_runtime_resume(struct device *dev)
 {
        struct fsl_asrc *asrc = dev_get_drvdata(dev);
        struct fsl_asrc_priv *asrc_priv = asrc->private;
+       int reg, retry = INIT_RETRY_NUM;
        int i, ret;
        u32 asrctr;
 
@@ -1295,6 +1304,24 @@ static int fsl_asrc_runtime_resume(struct device *dev)
        regmap_update_bits(asrc->regmap, REG_ASRCTR,
                           ASRCTR_ASRCEi_ALL_MASK, asrctr);
 
+       /* Wait for status of initialization for all enabled pairs */
+       do {
+               udelay(5);
+               regmap_read(asrc->regmap, REG_ASRCFG, &reg);
+               reg = (reg >> ASRCFG_INIRQi_SHIFT(0)) & 0x7;
+       } while ((reg != ((asrctr >> ASRCTR_ASRCEi_SHIFT(0)) & 0x7)) && --retry);
+
+       /*
+        * NOTE: Doesn't treat initialization timeout as an error
+        * Some of the pairs may success, then still can continue.
+        */
+       if (!retry) {
+               for (i = ASRC_PAIR_A; i < ASRC_PAIR_MAX_NUM; i++) {
+                       if ((asrctr & ASRCTR_ASRCEi_MASK(i)) && !(reg & (1 << i)))
+                               dev_warn(dev, "Pair %c initialization isn't finished\n", 'A' + i);
+               }
+       }
+
        return 0;
 
 disable_asrck_clk: