]> www.infradead.org Git - users/dwmw2/qemu.git/commitdiff
vfio/pci: Remove PCIe Link Status emulation
authorAlex Williamson <alex.williamson@redhat.com>
Wed, 12 Dec 2018 19:39:56 +0000 (12:39 -0700)
committerMichael S. Tsirkin <mst@redhat.com>
Wed, 19 Dec 2018 21:48:16 +0000 (16:48 -0500)
Now that the downstream port will virtually negotiate itself to the
link status of the downstream device, we can remove this emulation.
It's not clear that it was every terribly useful anyway.

Tested-by: Geoffrey McRae <geoff@hostfission.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
hw/vfio/pci.c

index 74f9a46b4be02816c8974c1e4cd9d3c96544f4ef..c0cb1ec289084eb1593f24dc423e647f4b29eb74 100644 (file)
@@ -1901,12 +1901,6 @@ static int vfio_setup_pcie_cap(VFIOPCIDevice *vdev, int pos, uint8_t size,
                            QEMU_PCI_EXP_LNKCAP_MLS(QEMU_PCI_EXP_LNK_2_5GT), ~0);
             vfio_add_emulated_word(vdev, pos + PCI_EXP_LNKCTL, 0, ~0);
         }
-
-        /* Mark the Link Status bits as emulated to allow virtual negotiation */
-        vfio_add_emulated_word(vdev, pos + PCI_EXP_LNKSTA,
-                               pci_get_word(vdev->pdev.config + pos +
-                                            PCI_EXP_LNKSTA),
-                               PCI_EXP_LNKCAP_MLW | PCI_EXP_LNKCAP_SLS);
     }
 
     /*