]> www.infradead.org Git - users/hch/xfsprogs.git/commitdiff
xfs: remove duplicate asserts in xfs_defer_extent_free
authorChristoph Hellwig <hch@lst.de>
Wed, 3 Jul 2024 21:21:39 +0000 (14:21 -0700)
committerDarrick J. Wong <djwong@kernel.org>
Tue, 30 Jul 2024 00:13:13 +0000 (17:13 -0700)
The bno/len verification is already done by the calls to
xfs_verify_rtbext / xfs_verify_fsbext, and reporting a corruption error
seem like the better handling than tripping an assert anyway.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
libxfs/xfs_alloc.c

index 6f792d280b3edbb0723844736ec6ea37f251e235..93e628e8c4577fb8b6e77ab70050c644c3630eef 100644 (file)
@@ -2563,23 +2563,10 @@ xfs_defer_extent_free(
 {
        struct xfs_extent_free_item     *xefi;
        struct xfs_mount                *mp = tp->t_mountp;
-#ifdef DEBUG
-       xfs_agnumber_t                  agno;
-       xfs_agblock_t                   agbno;
 
-       ASSERT(bno != NULLFSBLOCK);
-       ASSERT(len > 0);
        ASSERT(len <= XFS_MAX_BMBT_EXTLEN);
        ASSERT(!isnullstartblock(bno));
-       agno = XFS_FSB_TO_AGNO(mp, bno);
-       agbno = XFS_FSB_TO_AGBNO(mp, bno);
-       ASSERT(agno < mp->m_sb.sb_agcount);
-       ASSERT(agbno < mp->m_sb.sb_agblocks);
-       ASSERT(len < mp->m_sb.sb_agblocks);
-       ASSERT(agbno + len <= mp->m_sb.sb_agblocks);
-#endif
        ASSERT(!(free_flags & ~XFS_FREE_EXTENT_ALL_FLAGS));
-       ASSERT(xfs_extfree_item_cache != NULL);
        ASSERT(type != XFS_AG_RESV_AGFL);
 
        if (XFS_IS_CORRUPT(mp, !xfs_verify_fsbext(mp, bno, len)))