btrfs: disallow NODATACOW in ZONED mode

NODATACOW implies overwriting the file data on a device, which is
impossible in sequential required zones. Disable NODATACOW globally with
mount option and per-file NODATACOW attribute by masking FS_NOCOW_FL.

Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index a5dc7cc5d705cca6cd254bc057e5390dfb65e5dc..0b5e1df24906d551676b6d10efcd6ce5176b894f 100644 (file)
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -193,6 +193,15 @@ static int check_fsflags(unsigned int old_flags, unsigned int flags)
        return 0;
 }
 
+static int check_fsflags_compatible(struct btrfs_fs_info *fs_info,
+                                   unsigned int flags)
+{
+       if (btrfs_is_zoned(fs_info) && (flags & FS_NOCOW_FL))
+               return -EPERM;
+
+       return 0;
+}
+
 static int btrfs_ioctl_setflags(struct file *file, void __user *arg)
 {
        struct inode *inode = file_inode(file);
@@ -230,6 +239,10 @@ static int btrfs_ioctl_setflags(struct file *file, void __user *arg)
        if (ret)
                goto out_unlock;
 
+       ret = check_fsflags_compatible(fs_info, fsflags);
+       if (ret)
+               goto out_unlock;
+
        binode_flags = binode->flags;
        if (fsflags & FS_SYNC_FL)
                binode_flags |= BTRFS_INODE_SYNC;

diff --git a/fs/btrfs/zoned.c b/fs/btrfs/zoned.c
index 3bc6a5e3a61cd4f6b079bc86b61d6d371b6e633f..6ef97996e18528c7c7c27e5d046cc0d9326065d7 100644 (file)
--- a/fs/btrfs/zoned.c
+++ b/fs/btrfs/zoned.c
@@ -274,5 +274,10 @@ int btrfs_check_mountopts_zoned(struct btrfs_fs_info *info)
                return -EINVAL;
        }
 
+       if (btrfs_test_opt(info, NODATACOW)) {
+               btrfs_err(info, "zoned: NODATACOW not supported");
+               return -EINVAL;
+       }
+
        return 0;
 }