]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
iio: adc: ad7606: move 'val' pointer to ad7606_scan_direct()
authorAlexandru Ardelean <aardelean@baylibre.com>
Thu, 19 Sep 2024 13:04:37 +0000 (16:04 +0300)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 30 Sep 2024 08:21:04 +0000 (09:21 +0100)
The ad7606_scan_direct() function returns 'int', which is fine for 16-bit
samples.
But when going to 18-bit samples, these need to be implemented as 32-bit
(or int) type.

In that case when getting samples (which can be negative), we'd get random
error codes.
So, the easiest thing is to just move the 'val' pointer to
'ad7606_scan_direct()'. This doesn't qualify as a fix, it's just a
preparation for 18-bit ADCs (of the AD7606 family).

Reviewed-by: David Lechner <dlechner@baylibre.com>
Signed-off-by: Alexandru Ardelean <aardelean@baylibre.com>
Link: https://patch.msgid.link/20240919130444.2100447-3-aardelean@baylibre.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/ad7606.c

index 8ebfe8abc3f4630553364d8042f756a40a6698d3..032a8135c912514d72f118767eaabdebd2b2a7b1 100644 (file)
@@ -114,7 +114,8 @@ error_ret:
        return IRQ_HANDLED;
 }
 
-static int ad7606_scan_direct(struct iio_dev *indio_dev, unsigned int ch)
+static int ad7606_scan_direct(struct iio_dev *indio_dev, unsigned int ch,
+                             int *val)
 {
        struct ad7606_state *st = iio_priv(indio_dev);
        int ret;
@@ -128,8 +129,10 @@ static int ad7606_scan_direct(struct iio_dev *indio_dev, unsigned int ch)
        }
 
        ret = ad7606_read_samples(st);
-       if (ret == 0)
-               ret = st->data[ch];
+       if (ret)
+               goto error_ret;
+
+       *val = sign_extend32(st->data[ch], 15);
 
 error_ret:
        gpiod_set_value(st->gpio_convst, 0);
@@ -149,10 +152,9 @@ static int ad7606_read_raw(struct iio_dev *indio_dev,
        switch (m) {
        case IIO_CHAN_INFO_RAW:
                iio_device_claim_direct_scoped(return -EBUSY, indio_dev) {
-                       ret = ad7606_scan_direct(indio_dev, chan->address);
+                       ret = ad7606_scan_direct(indio_dev, chan->address, val);
                        if (ret < 0)
                                return ret;
-                       *val = (short) ret;
                        return IIO_VAL_INT;
                }
                unreachable();