netdev: prevent accessing NAPI instances from another namespace

The NAPI IDs were not fully exposed to user space prior to the netlink
API, so they were never namespaced. The netlink API must ensure that
at the very least NAPI instance belongs to the same netns as the owner
of the genl sock.

napi_by_id() can become static now, but it needs to move because of
dev_get_by_napi_id().

Cc: stable@vger.kernel.org
Fixes: 1287c1ae0fc2 ("netdev-genl: Support setting per-NAPI config values")
Fixes: 27f91aaf49b3 ("netdev-genl: Add netlink framework functions for napi")
Reviewed-by: Sridhar Samudrala <sridhar.samudrala@intel.com>
Reviewed-by: Joe Damato <jdamato@fastly.com>
Link: https://patch.msgid.link/20250106180137.1861472-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/net/core/dev.c b/net/core/dev.c
index faa23042df3846a89d0524a3286a5b0d4c3339b6..a9f62f5aeb84061069db7cf1add9fc6f2f219a37 100644 (file)
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -753,6 +753,36 @@ int dev_fill_forward_path(const struct net_device *dev, const u8 *daddr,
 }
 EXPORT_SYMBOL_GPL(dev_fill_forward_path);
 
+/* must be called under rcu_read_lock(), as we dont take a reference */
+static struct napi_struct *napi_by_id(unsigned int napi_id)
+{
+       unsigned int hash = napi_id % HASH_SIZE(napi_hash);
+       struct napi_struct *napi;
+
+       hlist_for_each_entry_rcu(napi, &napi_hash[hash], napi_hash_node)
+               if (napi->napi_id == napi_id)
+                       return napi;
+
+       return NULL;
+}
+
+/* must be called under rcu_read_lock(), as we dont take a reference */
+struct napi_struct *netdev_napi_by_id(struct net *net, unsigned int napi_id)
+{
+       struct napi_struct *napi;
+
+       napi = napi_by_id(napi_id);
+       if (!napi)
+               return NULL;
+
+       if (WARN_ON_ONCE(!napi->dev))
+               return NULL;
+       if (!net_eq(net, dev_net(napi->dev)))
+               return NULL;
+
+       return napi;
+}
+
 /**
  *     __dev_get_by_name       - find a device by its name
  *     @net: the applicable net namespace
@@ -6293,19 +6323,6 @@ bool napi_complete_done(struct napi_struct *n, int work_done)
 }
 EXPORT_SYMBOL(napi_complete_done);
 
-/* must be called under rcu_read_lock(), as we dont take a reference */
-struct napi_struct *napi_by_id(unsigned int napi_id)
-{
-       unsigned int hash = napi_id % HASH_SIZE(napi_hash);
-       struct napi_struct *napi;
-
-       hlist_for_each_entry_rcu(napi, &napi_hash[hash], napi_hash_node)
-               if (napi->napi_id == napi_id)
-                       return napi;
-
-       return NULL;
-}
-
 static void skb_defer_free_flush(struct softnet_data *sd)
 {
        struct sk_buff *skb, *next;

diff --git a/net/core/dev.h b/net/core/dev.h
index d043dee25a6854cf6eb431373ff6be6b20bbe67c..deb5eae5749fa0efca0039c38b753131da9137a2 100644 (file)
--- a/net/core/dev.h
+++ b/net/core/dev.h
@@ -22,6 +22,8 @@ struct sd_flow_limit {
 
 extern int netdev_flow_limit_table_len;
 
+struct napi_struct *netdev_napi_by_id(struct net *net, unsigned int napi_id);
+
 #ifdef CONFIG_PROC_FS
 int __init dev_proc_init(void);
 #else
@@ -269,7 +271,6 @@ void xdp_do_check_flushed(struct napi_struct *napi);
 static inline void xdp_do_check_flushed(struct napi_struct *napi) { }
 #endif
 
-struct napi_struct *napi_by_id(unsigned int napi_id);
 void kick_defer_list_purge(struct softnet_data *sd, unsigned int cpu);
 
 #define XMIT_RECURSION_LIMIT   8

diff --git a/net/core/netdev-genl.c b/net/core/netdev-genl.c
index 125b660004d38ffe3175422c033acd5e4cbffa03..a3bdaf075b6b95d16da0ff4ad0d625d370b8c985 100644 (file)
--- a/net/core/netdev-genl.c
+++ b/net/core/netdev-genl.c
@@ -167,8 +167,6 @@ netdev_nl_napi_fill_one(struct sk_buff *rsp, struct napi_struct *napi,
        void *hdr;
        pid_t pid;
 
-       if (WARN_ON_ONCE(!napi->dev))
-               return -EINVAL;
        if (!(napi->dev->flags & IFF_UP))
                return 0;
 
@@ -234,7 +232,7 @@ int netdev_nl_napi_get_doit(struct sk_buff *skb, struct genl_info *info)
        rtnl_lock();
        rcu_read_lock();
 
-       napi = napi_by_id(napi_id);
+       napi = netdev_napi_by_id(genl_info_net(info), napi_id);
        if (napi) {
                err = netdev_nl_napi_fill_one(rsp, napi, info);
        } else {
@@ -355,7 +353,7 @@ int netdev_nl_napi_set_doit(struct sk_buff *skb, struct genl_info *info)
        rtnl_lock();
        rcu_read_lock();
 
-       napi = napi_by_id(napi_id);
+       napi = netdev_napi_by_id(genl_info_net(info), napi_id);
        if (napi) {
                err = netdev_nl_napi_set_config(napi, info);
        } else {