]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
bpf: Use precise image size for struct_ops trampoline
authorPu Lehui <pulehui@huawei.com>
Sat, 22 Jun 2024 03:04:35 +0000 (03:04 +0000)
committerDaniel Borkmann <daniel@iogearbox.net>
Mon, 1 Jul 2024 15:10:46 +0000 (17:10 +0200)
For trampoline using bpf_prog_pack, we need to generate a rw_image
buffer with size of (image_end - image). For regular trampoline, we use
the precise image size generated by arch_bpf_trampoline_size to allocate
rw_image. But for struct_ops trampoline, we allocate rw_image directly
using close to PAGE_SIZE size. We do not need to allocate for that much,
as the patch size is usually much smaller than PAGE_SIZE. Let's use
precise image size for it too.

Signed-off-by: Pu Lehui <pulehui@huawei.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Tested-by: Björn Töpel <bjorn@rivosinc.com> #riscv
Acked-by: Song Liu <song@kernel.org>
Link: https://lore.kernel.org/bpf/20240622030437.3973492-2-pulehui@huaweicloud.com
kernel/bpf/bpf_struct_ops.c

index a2cf31b14be46de4128e7dbe37b333f413eb7b8d..0d515ec57aa5588dae4a1ba9abf3c63a84fa8411 100644 (file)
@@ -573,7 +573,7 @@ int bpf_struct_ops_prepare_trampoline(struct bpf_tramp_links *tlinks,
        }
 
        size = arch_prepare_bpf_trampoline(NULL, image + image_off,
-                                          image + PAGE_SIZE,
+                                          image + image_off + size,
                                           model, flags, tlinks, stub_func);
        if (size <= 0) {
                if (image != *_image)