]> www.infradead.org Git - users/hch/block.git/commitdiff
sd: simplify the disable case in sd_config_discard
authorChristoph Hellwig <hch@lst.de>
Fri, 31 May 2024 07:48:03 +0000 (09:48 +0200)
committerJens Axboe <axboe@kernel.dk>
Fri, 14 Jun 2024 16:19:44 +0000 (10:19 -0600)
Fall through to the main call to blk_queue_max_discard_sectors given that
max_blocks has been initialized to zero above instead of duplicating the
call.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Link: https://lore.kernel.org/r/20240531074837.1648501-9-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/scsi/sd.c

index 70211d0b187652be5336d7a4a7f0005eaaaa5d66..0dbc6eb7a7cac3d66429a1c90f6d3968fb15c60e 100644 (file)
@@ -844,8 +844,7 @@ static void sd_config_discard(struct scsi_disk *sdkp, unsigned int mode)
 
        case SD_LBP_FULL:
        case SD_LBP_DISABLE:
-               blk_queue_max_discard_sectors(q, 0);
-               return;
+               break;
 
        case SD_LBP_UNMAP:
                max_blocks = min_not_zero(sdkp->max_unmap_blocks,