]> www.infradead.org Git - users/dwmw2/qemu.git/commitdiff
block: Plug memory leak on brv_open_image() error path
authorMarkus Armbruster <armbru@redhat.com>
Wed, 28 May 2014 09:16:57 +0000 (11:16 +0200)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Tue, 5 Aug 2014 16:42:52 +0000 (11:42 -0500)
Introduced in commit da557a.  Spotted by Coverity.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
(cherry picked from commit b20e61e0d52eef57cf5db55087b16e0b5207e730)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
block.c

diff --git a/block.c b/block.c
index e3ba203d9fe4893d73e056286eb90ef0a455f54a..5448430147db6667d2dec1814b6d0f75d3589258 100644 (file)
--- a/block.c
+++ b/block.c
@@ -1158,6 +1158,7 @@ int bdrv_open_image(BlockDriverState **pbs, const char *filename,
                        bdref_key);
             ret = -EINVAL;
         }
+        QDECREF(image_options);
         goto done;
     }