]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
phy: twl4030-usb: remove incorrect pm_runtime_get_sync() in probe function.
authorNeilBrown <neil@brown.name>
Thu, 16 Apr 2015 08:03:04 +0000 (18:03 +1000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 3 Aug 2015 16:29:05 +0000 (09:29 -0700)
commit 4724e27114c4a7eceeee07db227a17fcab6f165c upstream.

The USB phy should initialize with power-off, and will be powered on
by the USB system when a cable connection is detected.

Having this pm_runtime_get_sync() during probe causes the phy to
*always* be powered on.
Removing it returns to sensible power management.

Fixes: 96be39ab34b77c6f6f5cd6ae03aac6c6449ee5c4
Signed-off-by: NeilBrown <neil@brown.name>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/phy/phy-twl4030-usb.c

index bc42d6a8939f4efd85fb1e10ea6d12faa1b76e97..8882afbef68856cb3ab089cb04611c54b05c1bca 100644 (file)
@@ -711,7 +711,6 @@ static int twl4030_usb_probe(struct platform_device *pdev)
        pm_runtime_use_autosuspend(&pdev->dev);
        pm_runtime_set_autosuspend_delay(&pdev->dev, 2000);
        pm_runtime_enable(&pdev->dev);
-       pm_runtime_get_sync(&pdev->dev);
 
        /* Our job is to use irqs and status from the power module
         * to keep the transceiver disabled when nothing's connected.