NFSD: Remove dead code in nfsd4_create_session()

Clean up. AFAICT, there is no way to reach the out_free_conn label
with @old set to a non-NULL value, so the expire_client(old) call
is never reached and can be removed.

Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 2efceeea0fe3eae59ad054cda6fd6668421cd7c1..133117b6c7ccd2d896f09b5db6da48d606a79832 100644 (file)
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -3954,7 +3954,6 @@ nfsd4_create_session(struct svc_rqst *rqstp,
        return status;
 
 out_expired_error:
-       old = NULL;
        /*
         * Revert the slot seq_nr change so the server will process
         * the client's resend instead of returning a cached response.
@@ -3969,8 +3968,6 @@ out_cache_error:
 out_free_conn:
        spin_unlock(&nn->client_lock);
        free_conn(conn);
-       if (old)
-               expire_client(old);
 out_free_session:
        __free_session(new);
 out_release_drc_mem: