Address static analysis warning

auth.c:717:14: warning: Access to field 'auth_id' results in a dereference of a null pointer (loaded from variable 'form') [core.NullDereference]
  717 |         if (!strcmp(form->auth_id, "success"))
      |                     ^~~~~~~~~~~~~

Signed-off-by: Dimitri Papadopoulos Orfanos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>

diff --git a/auth.c b/auth.c
index ec17c2969da7e2cba7acd3ac284f64e552106ddb..6fe669f7ee1517efeb8d53459cd5832c11193411 100644 (file)
--- a/auth.c
+++ b/auth.c
@@ -714,6 +714,12 @@ static int handle_auth_form(struct openconnect_info *vpninfo, struct oc_auth_for
        int ret;
        struct oc_vpn_option *opt, *next;
 
+       if (!form) {
+               vpn_progress(vpninfo, PRG_DEBUG,
+                            "The authentication form is NULL\n");
+               return -EPERM;
+       }
+
        if (!strcmp(form->auth_id, "success"))
                return OC_FORM_RESULT_LOGGEDIN;