]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
dtrace: DTrace state deadman must use dtrace_sync()
authorTomas Jedlicka <tomas.jedlicka@oracle.com>
Thu, 29 Jun 2017 11:22:52 +0000 (07:22 -0400)
committerKris Van Hees <kris.van.hees@oracle.com>
Fri, 14 Jul 2017 04:11:35 +0000 (00:11 -0400)
The dtrace_sync() allows to check that all CPUs have left probe context. Wihtout this
code the deadman check would based its assumption on the state of CPU that calls
deadman cyclics which is wrong.

Orabug: 26385102

Signed-off-by: Tomas Jedlicka <tomas.jedlicka@oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>
dtrace/dtrace_state.c

index 2098d4e29bd599c0261a96ea9bf97c8872fd0a4e..e04214bae6c126742d49ec744428eb92d8499162 100644 (file)
@@ -301,12 +301,7 @@ static void dtrace_state_clean(dtrace_state_t *state, ktime_t when)
 
 static void dtrace_state_deadman(dtrace_state_t *state, ktime_t when)
 {
-#ifdef FIXME
-       /*
-        * This may not be needed for Linux - we'll see.
-        */
        dtrace_sync();
-#endif
 
        if (state != dtrace_anon.dta_state &&
            time_after_eq(jiffies, state->dts_laststatus + dtrace_deadman_user))