]> www.infradead.org Git - users/sagi/nvme-cli.git/commitdiff
nvme: fix io_mgmt args parse error
authorSteven Seungcheol Lee <sc108.lee@samsung.com>
Mon, 17 Apr 2023 03:09:59 +0000 (12:09 +0900)
committerDaniel Wagner <wagi@monom.org>
Mon, 17 Apr 2023 09:28:30 +0000 (11:28 +0200)
Since mos defined __u16, it should be parsed with OPT_SHRT
if mos given right after mo, it cause parse error
mo always set as 0

Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
Co-authored-by: Minsik Jeon <hmi.jeon@samsung.com>
Reported-by: Youngjin Jung <yj4369.jung@samsung.com>
nvme.c

diff --git a/nvme.c b/nvme.c
index 9331365e11b4535d04ee06e59d88e31e7b86e2cf..64990a60e87c53f2825e07a43cb282cc857fa424 100644 (file)
--- a/nvme.c
+++ b/nvme.c
@@ -2042,7 +2042,7 @@ static int io_mgmt_send(int argc, char **argv, struct command *cmd, struct plugi
 
        OPT_ARGS(opts) = {
                OPT_UINT("namespace-id",  'n', &cfg.namespace_id,   namespace_id_desired),
-               OPT_UINT("mos",           's', &cfg.mos,            mos),
+               OPT_SHRT("mos",           's', &cfg.mos,            mos),
                OPT_BYTE("mo",            'm', &cfg.mo,             mo),
                OPT_FILE("data",          'd', &cfg.file,           data),
                OPT_UINT("data-len",      'l', &cfg.data_len,       buf_len),
@@ -2138,7 +2138,7 @@ static int io_mgmt_recv(int argc, char **argv, struct command *cmd, struct plugi
 
        OPT_ARGS(opts) = {
                OPT_UINT("namespace-id",  'n', &cfg.namespace_id,   namespace_id_desired),
-               OPT_UINT("mos",           's', &cfg.mos,            mos),
+               OPT_SHRT("mos",           's', &cfg.mos,            mos),
                OPT_BYTE("mo",            'm', &cfg.mo,             mo),
                OPT_FILE("data",          'd', &cfg.file,           data),
                OPT_UINT("data-len",      'l', &cfg.data_len,       buf_len),