]> www.infradead.org Git - users/hch/xfstests-dev.git/commitdiff
common/populate: fix bash syntax error in _fill_fs
authorDarrick J. Wong <djwong@kernel.org>
Tue, 1 Oct 2024 16:48:56 +0000 (09:48 -0700)
committerZorro Lang <zlang@kernel.org>
Sat, 12 Oct 2024 14:06:30 +0000 (22:06 +0800)
In bash, one does not set a variable by prepending the dollar sign to
the variable name.  Amazingly, this was copied verbatim from generic/256
in 2016 and hasn't been caught since its introduction in 2011. :(

Cc: allison.henderson@oracle.com
Fixes: 815015e9ee ("generic: make 17[1-4] work well when btrfs compression is enabled")
Fixes: b55fb0807c ("xfstests: Add ENOSPC Hole Punch Test")
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Zorro Lang <zlang@kernel.org>
common/populate

index 9fda19df06a5097918d95f5c099b3ed2ba61ffa0..88c8ba2b32767cbc312aca5af23595d90b1d6499 100644 (file)
@@ -945,7 +945,7 @@ _fill_fs()
        echo $testio | grep -q "Operation not supported" && use_falloc=0
 
        if [ $file_size -lt $block_size ]; then
-               $file_size = $block_size
+               file_size=$block_size
        fi
 
        while [ $file_size -ge $block_size ]; do