]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
media: atomisp: add missing wait_prepare/finish ops
authorHans Verkuil <hverkuil-cisco@xs4all.nl>
Mon, 2 Sep 2024 08:31:21 +0000 (10:31 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Fri, 6 Sep 2024 09:56:54 +0000 (11:56 +0200)
Without these ops the v4l2-compliance blocking wait test will fail.
These ops are required to ensure that when VIDIOC_DQBUF has to
wait for buffers to arrive, the queue lock is correctly released
and retaken. Otherwise the wait for a buffer would block all other
queue ioctls.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Link: https://lore.kernel.org/r/9f401f3732dd728e3d2ca508002c97b80a2eae30.1725265884.git.hverkuil-cisco@xs4all.nl
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/atomisp/pci/atomisp_fops.c

index 50c4123ba006648db38c1e310bed4697d49615e0..b180fcbea9b1e6909cf3b6c2cf165684c6cf8667 100644 (file)
@@ -441,6 +441,8 @@ const struct vb2_ops atomisp_vb2_ops = {
        .buf_queue              = atomisp_buf_queue,
        .start_streaming        = atomisp_start_streaming,
        .stop_streaming         = atomisp_stop_streaming,
+       .wait_prepare           = vb2_ops_wait_prepare,
+       .wait_finish            = vb2_ops_wait_finish,
 };
 
 static void atomisp_dev_init_struct(struct atomisp_device *isp)