tests: check for invalid subsystem names

Signed-off-by: Christoph Hellwig <hch@lst.de>

diff --git a/nvmet/test_nvmet.py b/nvmet/test_nvmet.py
index b092baa42e36096463f63d0dcbc080a804c1629e..5654c59d6b96829e08ec2b1d2fd7fb9fed7309e5 100644 (file)
--- a/nvmet/test_nvmet.py
+++ b/nvmet/test_nvmet.py
@@ -1,4 +1,6 @@
 
+import random
+import string
 import unittest
 import nvmet.nvme as nvme
 
@@ -146,6 +148,25 @@ class TestNvmet(unittest.TestCase):
         s.delete()
         self.assertEqual(len(list(root.subsystems)), 0)
 
+    def test_invalid_input(self):
+        root = nvme.Root()
+        root.clear_existing()
+
+        self.assertRaises(nvme.CFSError, nvme.Subsystem,
+                          nqn='', mode='create')
+        self.assertRaises(nvme.CFSError, nvme.Subsystem,
+                          nqn='/', mode='create')
+
+        for l in [ 257, 512, 1024, 2048 ]:
+            toolong = ''.join(random.choice(string.lowercase)
+                              for i in range(l))
+            self.assertRaises(nvme.CFSError, nvme.Subsystem,
+                              nqn=toolong, mode='create')
+
+        discover_nqn = "nqn.2014-08.org.nvmexpress.discovery"
+        self.assertRaises(nvme.CFSError, nvme.Subsystem,
+                          nqn=discover_nqn, mode='create')
+
     def test_save_restore(self):
         root = nvme.Root()
         root.clear_existing()