]> www.infradead.org Git - nvme.git/commitdiff
drm/amd/display: amend HPD handler for Replay
authorChunTao Tso <chuntao.tso@amd.com>
Tue, 3 Oct 2023 09:05:05 +0000 (17:05 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 7 Nov 2023 17:03:06 +0000 (12:03 -0500)
[Why]
For Replay, if we receive HPD, it doesn’t need to reboot the display.
We don’t need to return anything exactly.

[How]
Return nothing just because we don’t need to reboot the display.

Signed-off-by: ChunTao Tso <chuntao.tso@amd.com>
Acked-by: Hersen Wu <hersenxs.wu@amd.com>
Reviewed-by: Jerry Zuo <jerry.zuo@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_irq_handler.c

index fc14c364414433c63ecb70aafb44596c4745a6bc..06e829ef48af24a99b4a37efd79fd35cd1cb6e5d 100644 (file)
@@ -184,17 +184,17 @@ static bool handle_hpd_irq_psr_sink(struct dc_link *link)
        return false;
 }
 
-static bool handle_hpd_irq_replay_sink(struct dc_link *link)
+static void handle_hpd_irq_replay_sink(struct dc_link *link)
 {
        union dpcd_replay_configuration replay_configuration;
        /*AMD Replay version reuse DP_PSR_ERROR_STATUS for REPLAY_ERROR status.*/
        union psr_error_status replay_error_status;
 
        if (link->replay_settings.config.force_disable_desync_error_check)
-               return true;
+               return;
 
        if (!link->replay_settings.replay_feature_enabled)
-               return false;
+               return;
 
        dm_helpers_dp_read_dpcd(
                link->ctx,
@@ -246,7 +246,6 @@ static bool handle_hpd_irq_replay_sink(struct dc_link *link)
                        edp_set_replay_allow_active(link, &allow_active, true, false, NULL);
                }
        }
-       return true;
 }
 
 void dp_handle_link_loss(struct dc_link *link)
@@ -427,9 +426,7 @@ bool dp_handle_hpd_rx_irq(struct dc_link *link,
                /* PSR-related error was detected and handled */
                return true;
 
-       if (handle_hpd_irq_replay_sink(link))
-               /* Replay-related error was detected and handled */
-               return true;
+       handle_hpd_irq_replay_sink(link);
 
        /* If PSR-related error handled, Main link may be off,
         * so do not handle as a normal sink status change interrupt.