]> www.infradead.org Git - users/willy/xarray.git/commitdiff
HID: logitech-dj: Fix memory leak in logi_dj_recv_switch_to_dj_mode()
authorJosé Expósito <jose.exposito89@gmail.com>
Fri, 24 May 2024 13:05:39 +0000 (15:05 +0200)
committerJiri Kosina <jkosina@suse.com>
Tue, 4 Jun 2024 14:16:37 +0000 (16:16 +0200)
Fix a memory leak on logi_dj_recv_send_report() error path.

Fixes: 6f20d3261265 ("HID: logitech-dj: Fix error handling in logi_dj_recv_switch_to_dj_mode()")
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/hid-logitech-dj.c

index 3c3c497b6b91141bb2948b1a124b1a144f1a4fdf..37958edec55f5f9e97ee1ca316c5254139c343e3 100644 (file)
@@ -1284,8 +1284,10 @@ static int logi_dj_recv_switch_to_dj_mode(struct dj_receiver_dev *djrcv_dev,
                 */
                msleep(50);
 
-               if (retval)
+               if (retval) {
+                       kfree(dj_report);
                        return retval;
+               }
        }
 
        /*