rtos: chibios: replace malloc+sprintf with alloc_printf

This makes it safer and simpler at the same time.

Signed-off-by: Paul Fertser <fercerpav@gmail.com>
Change-Id: Ie294f1f6033ffc9f46b39210e2f7fc2f648e80ac
Reviewed-on: https://review.openocd.org/c/openocd/+/8598
Tested-by: jenkins
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>

diff --git a/src/rtos/chibios.c b/src/rtos/chibios.c
index f4ee33a490cc646b31b6dbc6a2b526842ab83054..af590c2cb1ced65a4140cf37cdf02ff35cb063f1 100644 (file)
--- a/src/rtos/chibios.c
+++ b/src/rtos/chibios.c
@@ -421,9 +421,11 @@ static int chibios_update_threads(struct rtos *rtos)
                else
                        state_desc = "Unknown";
 
-               curr_thrd_details->extra_info_str = malloc(strlen(
-                                       state_desc)+8);
-               sprintf(curr_thrd_details->extra_info_str, "State: %s", state_desc);
+               curr_thrd_details->extra_info_str = alloc_printf("State: %s", state_desc);
+               if (!curr_thrd_details->extra_info_str) {
+                       LOG_ERROR("Could not allocate space for thread state description");
+                       return -1;
+               }
 
                curr_thrd_details->exists = true;