ALSA: als100: Fix assignment in if condition

ISA ALS100 driver code contains lots of assignments in if condition,
which is a bad coding style that may confuse readers and occasionally
lead to bugs.

This patch is merely for coding-style fixes, no functional changes.

Link: https://lore.kernel.org/r/20210608140540.17885-13-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>

diff --git a/sound/isa/als100.c b/sound/isa/als100.c
index bacb7a1b930c0bd15d4bb52425a89fc2672c427a..d4597fdfe091de6cfd3d0815f0e3e200cea9fcc7 100644 (file)
--- a/sound/isa/als100.c
+++ b/sound/isa/als100.c
@@ -177,7 +177,8 @@ static int snd_card_als100_probe(int dev,
                return error;
        acard = card->private_data;
 
-       if ((error = snd_card_als100_pnp(dev, acard, pcard, pid))) {
+       error = snd_card_als100_pnp(dev, acard, pcard, pid);
+       if (error) {
                snd_card_free(card);
                return error;
        }
@@ -211,12 +212,14 @@ static int snd_card_als100_probe(int dev,
                         dma16[dev]);
        }
 
-       if ((error = snd_sb16dsp_pcm(chip, 0)) < 0) {
+       error = snd_sb16dsp_pcm(chip, 0);
+       if (error < 0) {
                snd_card_free(card);
                return error;
        }
 
-       if ((error = snd_sbmixer_new(chip)) < 0) {
+       error = snd_sbmixer_new(chip);
+       if (error < 0) {
                snd_card_free(card);
                return error;
        }
@@ -245,18 +248,21 @@ static int snd_card_als100_probe(int dev,
                        snd_printk(KERN_ERR PFX "no OPL device at 0x%lx-0x%lx\n",
                                   fm_port[dev], fm_port[dev] + 2);
                } else {
-                       if ((error = snd_opl3_timer_new(opl3, 0, 1)) < 0) {
+                       error = snd_opl3_timer_new(opl3, 0, 1);
+                       if (error < 0) {
                                snd_card_free(card);
                                return error;
                        }
-                       if ((error = snd_opl3_hwdep_new(opl3, 0, 1, NULL)) < 0) {
+                       error = snd_opl3_hwdep_new(opl3, 0, 1, NULL);
+                       if (error < 0) {
                                snd_card_free(card);
                                return error;
                        }
                }
        }
 
-       if ((error = snd_card_register(card)) < 0) {
+       error = snd_card_register(card);
+       if (error < 0) {
                snd_card_free(card);
                return error;
        }