]> www.infradead.org Git - linux-platform-drivers-x86.git/commitdiff
ASoC: cs35l36: Fix an error handling path in 'cs35l36_i2c_probe()'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 11 Apr 2021 12:57:13 +0000 (14:57 +0200)
committerMark Brown <broonie@kernel.org>
Tue, 13 Apr 2021 13:12:55 +0000 (14:12 +0100)
If 'devm_regmap_init_i2c()' fails, there is no need to goto err. We should
return directly as already done by the surrounding error handling paths.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/9fec48e75bc1d3c92626e6f6aca2344bda223379.1618145790.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/cs35l36.c

index 4451ca9f49166f2d6dcb5171a1f033eeecff0ee9..a038bcec2d17c03c50254f21a767f065eab61722 100644 (file)
@@ -1721,7 +1721,7 @@ static int cs35l36_i2c_probe(struct i2c_client *i2c_client,
        if (IS_ERR(cs35l36->regmap)) {
                ret = PTR_ERR(cs35l36->regmap);
                dev_err(dev, "regmap_init() failed: %d\n", ret);
-               goto err;
+               return ret;
        }
 
        cs35l36->num_supplies = ARRAY_SIZE(cs35l36_supplies);