]> www.infradead.org Git - users/hch/misc.git/commitdiff
module: Use RCU in module_kallsyms_on_each_symbol().
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Wed, 8 Jan 2025 09:04:37 +0000 (10:04 +0100)
committerPetr Pavlu <petr.pavlu@suse.com>
Mon, 10 Mar 2025 10:54:44 +0000 (11:54 +0100)
module::kallsyms can be accessed under RCU assumption.

Use rcu_dereference() to access module::kallsyms.
Update callers.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/r/20250108090457.512198-9-bigeasy@linutronix.de
Signed-off-by: Petr Pavlu <petr.pavlu@suse.com>
kernel/module/kallsyms.c

index e3c55bc879c110c61cdcce0641d616644b748440..0e8ec6486d95c8362d847d550d09ec6922d408f3 100644 (file)
@@ -476,10 +476,8 @@ int module_kallsyms_on_each_symbol(const char *modname,
                if (modname && strcmp(modname, mod->name))
                        continue;
 
-               /* Use rcu_dereference_sched() to remain compliant with the sparse tool */
-               preempt_disable();
-               kallsyms = rcu_dereference_sched(mod->kallsyms);
-               preempt_enable();
+               kallsyms = rcu_dereference_check(mod->kallsyms,
+                                                lockdep_is_held(&module_mutex));
 
                for (i = 0; i < kallsyms->num_symtab; i++) {
                        const Elf_Sym *sym = &kallsyms->symtab[i];