]> www.infradead.org Git - users/sagi/blktests.git/commitdiff
block/008: fix shellcheck warnings
authorOmar Sandoval <osandov@fb.com>
Mon, 11 Jun 2018 20:34:40 +0000 (13:34 -0700)
committerOmar Sandoval <osandov@fb.com>
Mon, 11 Jun 2018 20:34:40 +0000 (13:34 -0700)
tests/block/008:68:10: warning: Quote arguments to unset so they're not glob expanded. [SC2184]
tests/block/008:74:10: warning: Quote arguments to unset so they're not glob expanded. [SC2184]

Signed-off-by: Omar Sandoval <osandov@fb.com>
tests/block/008

index 4534dc3b54aa90812441510e507a1fa2a512ef52..fcd905adcfe8ef45ca7a193d016a8b08ee501641 100755 (executable)
@@ -63,17 +63,15 @@ test_device() {
 
                if (( offlining )); then
                        idx=$((RANDOM % ${#online_cpus[@]}))
-                       echo "offlining $idx (online=${online_cpus[@]} offline=${offline_cpus[@]})" >> /dev/kmsg
                        _offline_cpu "${online_cpus[$idx]}"
                        offline_cpus+=("${online_cpus[$idx]}")
-                       unset online_cpus[$idx]
+                       unset online_cpus["$idx"]
                        online_cpus=("${online_cpus[@]}")
                else
                        idx=$((RANDOM % ${#offline_cpus[@]}))
-                       echo "onlining $idx (online=${online_cpus[@]} offline=${offline_cpus[@]})" >> /dev/kmsg
                        _online_cpu "${offline_cpus[$idx]}"
                        online_cpus+=("${offline_cpus[$idx]}")
-                       unset offline_cpus[$idx]
+                       unset offline_cpus["$idx"]
                        offline_cpus=("${offline_cpus[@]}")
                fi