]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
drm/i915/scaler: Fix WA_14011503117
authorSuraj Kandpal <suraj.kandpal@intel.com>
Wed, 6 Aug 2025 03:08:56 +0000 (08:38 +0530)
committerSuraj Kandpal <suraj.kandpal@intel.com>
Wed, 6 Aug 2025 06:13:42 +0000 (11:43 +0530)
This introduces and uses a variable id which is just uninitialized.
What really needs to be used is the scaler_id.

Fixes: 73309ed9d598 ("drm/i915/display: WA_14011503117")
Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
Reviewed-by: Nemesa Garg <nemesa.garg@intel.com>
Link: https://lore.kernel.org/r/20250806030856.3514127-1-suraj.kandpal@intel.com
drivers/gpu/drm/i915/display/skl_scaler.c

index 1374fa94ff5ce92c998b9265280d92565a4b9390..cd7ebbeb950841d77296e57dc11da6c86bfff053 100644 (file)
@@ -959,11 +959,12 @@ void adl_scaler_ecc_unmask(const struct intel_crtc_state *crtc_state)
        struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
        const struct intel_crtc_scaler_state *scaler_state =
                &crtc_state->scaler_state;
-       int id;
 
        if (!scaler_state && scaler_state->scaler_id == -1)
                return;
 
-       intel_de_write_fw(display, SKL_PS_ECC_STAT(crtc->pipe, id), 1);
+       intel_de_write_fw(display,
+                         SKL_PS_ECC_STAT(crtc->pipe, scaler_state->scaler_id),
+                         1);
        intel_de_write(display, XELPD_DISPLAY_ERR_FATAL_MASK, 0);
 }