]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
io_uring/poll: remove outdated comments of caching
authorLin Ma <linma@zju.edu.cn>
Thu, 10 Nov 2022 06:03:13 +0000 (14:03 +0800)
committerJens Axboe <axboe@kernel.dk>
Mon, 21 Nov 2022 14:44:14 +0000 (07:44 -0700)
Previous commit 13a99017ff19 ("io_uring: remove events caching
atavisms") entirely removes the events caching optimization introduced
by commit 81459350d581 ("io_uring: cache req->apoll->events in
req->cflags"). Hence the related comment should also be removed to avoid
misunderstanding.

Fixes: 13a99017ff19 ("io_uring: remove events caching atavisms")
Signed-off-by: Lin Ma <linma@zju.edu.cn>
Link: https://lore.kernel.org/r/20221110060313.16303-1-linma@zju.edu.cn
Signed-off-by: Jens Axboe <axboe@kernel.dk>
io_uring/poll.c

index 58e02d9639612fd2e0a02bc23aa1d374d5ce341b..8fb8e781c02decbc4b96bb883d403f6d1ecbb21c 100644 (file)
@@ -324,12 +324,7 @@ static void io_apoll_task_func(struct io_kiocb *req, bool *locked)
 static void __io_poll_execute(struct io_kiocb *req, int mask)
 {
        io_req_set_res(req, mask, 0);
-       /*
-        * This is useful for poll that is armed on behalf of another
-        * request, and where the wakeup path could be on a different
-        * CPU. We want to avoid pulling in req->apoll->events for that
-        * case.
-        */
+
        if (req->opcode == IORING_OP_POLL_ADD)
                req->io_task_work.func = io_poll_task_func;
        else