]> www.infradead.org Git - users/hch/misc.git/commitdiff
drm/amdkfd: Fix error code sign for EINVAL in svm_ioctl()
authorQianfeng Rong <rongqianfeng@vivo.com>
Thu, 4 Sep 2025 12:36:46 +0000 (20:36 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 5 Sep 2025 21:38:39 +0000 (17:38 -0400)
Use negative error code -EINVAL instead of positive EINVAL in the default
case of svm_ioctl() to conform to Linux kernel error code conventions.

Fixes: 42de677f7999 ("drm/amdkfd: register svm range")
Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdkfd/kfd_svm.c

index 521c14c7a789366a2a4d0e4295faf21273d8699b..68ba239b2e5db07c23f5210510013477a7e036a4 100644 (file)
@@ -4261,7 +4261,7 @@ svm_ioctl(struct kfd_process *p, enum kfd_ioctl_svm_op op, uint64_t start,
                r = svm_range_get_attr(p, mm, start, size, nattrs, attrs);
                break;
        default:
-               r = EINVAL;
+               r = -EINVAL;
                break;
        }