]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
PCI: brcmstb: Fix window register offset from 4 to 8
authorJim Quinlan <jquinlan@broadcom.com>
Thu, 7 May 2020 20:15:41 +0000 (16:15 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 24 Jun 2020 15:48:21 +0000 (17:48 +0200)
[ Upstream commit 077a4fa92a615a4d0f86eae68d777b9dd5e5a95b ]

The outbound memory window registers were being referenced
with an incorrect stride offset.  This probably wasn't noticed
previously as there was likely only one such window employed.

Link: https://lore.kernel.org/r/20200507201544.43432-3-james.quinlan@broadcom.com
Fixes: c0452137034b ("PCI: brcmstb: Add Broadcom STB PCIe host controller driver")
Signed-off-by: Jim Quinlan <jquinlan@broadcom.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pci/controller/pcie-brcmstb.c

index 6d79d14527a6632333609858d4843a27d98ff290..c9ecc4d639c19cd90698b2b70b8f2daac56eaeb1 100644 (file)
 
 #define PCIE_MISC_CPU_2_PCIE_MEM_WIN0_LO               0x400c
 #define PCIE_MEM_WIN0_LO(win)  \
-               PCIE_MISC_CPU_2_PCIE_MEM_WIN0_LO + ((win) * 4)
+               PCIE_MISC_CPU_2_PCIE_MEM_WIN0_LO + ((win) * 8)
 
 #define PCIE_MISC_CPU_2_PCIE_MEM_WIN0_HI               0x4010
 #define PCIE_MEM_WIN0_HI(win)  \
-               PCIE_MISC_CPU_2_PCIE_MEM_WIN0_HI + ((win) * 4)
+               PCIE_MISC_CPU_2_PCIE_MEM_WIN0_HI + ((win) * 8)
 
 #define PCIE_MISC_RC_BAR1_CONFIG_LO                    0x402c
 #define  PCIE_MISC_RC_BAR1_CONFIG_LO_SIZE_MASK         0x1f