]> www.infradead.org Git - users/hch/configfs.git/commitdiff
r8152: Set NET_ADDR_STOLEN if using passthru MAC
authorMilan Broz <gmazyland@gmail.com>
Wed, 5 Jun 2024 15:33:40 +0000 (17:33 +0200)
committerJakub Kicinski <kuba@kernel.org>
Fri, 7 Jun 2024 00:33:12 +0000 (17:33 -0700)
Some docks support MAC pass-through - MAC address
is taken from another device.

Driver should indicate that with NET_ADDR_STOLEN flag.

This should help to avoid collisions if network interface
names are generated with MAC policy.

Reported and discussed here
https://github.com/systemd/systemd/issues/33104

Signed-off-by: Milan Broz <gmazyland@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20240605153340.25694-1-gmazyland@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/usb/r8152.c

index 09fe70bc45d4852cb8b3c73f8937bfe4774fd45e..15e12f46d0ea2950bc3a4558e27abc7c355d66b5 100644 (file)
@@ -1774,6 +1774,7 @@ static int vendor_mac_passthru_addr_read(struct r8152 *tp, struct sockaddr *sa)
                goto amacout;
        }
        memcpy(sa->sa_data, buf, 6);
+       tp->netdev->addr_assign_type = NET_ADDR_STOLEN;
        netif_info(tp, probe, tp->netdev,
                   "Using pass-thru MAC addr %pM\n", sa->sa_data);