]> www.infradead.org Git - nvme.git/commitdiff
drm/fbdev-dma: Fix framebuffer mode for big endian devices
authorThomas Huth <thuth@redhat.com>
Tue, 2 Jul 2024 12:17:37 +0000 (14:17 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Mon, 8 Jul 2024 14:28:00 +0000 (16:28 +0200)
The drm_mode_legacy_fb_format() function only generates formats suitable
for little endian devices. switch to drm_driver_legacy_fb_format() here
instead to take the device endianness into consideration, too.

Suggested-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Fixes: 6ae2ff23aa43 ("drm/client: Convert drm_client_buffer_addfb() to drm_mode_addfb2()")
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Javier Martinez Canillas <javierm@redhat.com>
Cc: Hamza Mahfooz <hamza.mahfooz@amd.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: <stable@vger.kernel.org> # v6.7+
Link: https://patchwork.freedesktop.org/patch/msgid/20240702121737.522878-1-thuth@redhat.com
drivers/gpu/drm/drm_fbdev_dma.c

index 97ef6300d47e0afa5cf3234b2c051a5e98a75b9c..fdef4a2f883f4d5b1257ccd302a47a05e3e131d9 100644 (file)
@@ -101,7 +101,8 @@ static int drm_fbdev_dma_helper_fb_probe(struct drm_fb_helper *fb_helper,
                    sizes->surface_width, sizes->surface_height,
                    sizes->surface_bpp);
 
-       format = drm_mode_legacy_fb_format(sizes->surface_bpp, sizes->surface_depth);
+       format = drm_driver_legacy_fb_format(dev, sizes->surface_bpp,
+                                            sizes->surface_depth);
        buffer = drm_client_framebuffer_create(client, sizes->surface_width,
                                               sizes->surface_height, format);
        if (IS_ERR(buffer))