]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
PCI: Declare pci_filp_private only when HAVE_PCI_MMAP
authorKrzysztof Wilczyński <kw@linux.com>
Tue, 6 Jul 2021 00:31:45 +0000 (00:31 +0000)
committerBjorn Helgaas <bhelgaas@google.com>
Tue, 22 Mar 2022 16:23:51 +0000 (11:23 -0500)
The struct pci_filp_private has no users outside drivers/pci/proc.c and is
only used when HAVE_PCI_MMAP is defined.

Wrap the struct pci_filp_private definition itself in #ifdef HAVE_PCI_MMAP.

Found by cppcheck:

  $ cppcheck --enable=all --force drivers/pci/proc.c
  drivers/pci/proc.c:192:6: style: struct member 'pci_filp_private::write_combine' is never used. [unusedStructMember]

Link: https://lore.kernel.org/r/20210706003145.3054881-1-kw@linux.com
Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
drivers/pci/proc.c

index 9c7edec64f7e24bed44b3cd8e6afd3b1b909a0d1..1a5b75399aa5a6196a53b63186fc5a812c41ee1b 100644 (file)
@@ -188,10 +188,12 @@ static ssize_t proc_bus_pci_write(struct file *file, const char __user *buf,
        return nbytes;
 }
 
+#ifdef HAVE_PCI_MMAP
 struct pci_filp_private {
        enum pci_mmap_state mmap_state;
        int write_combine;
 };
+#endif /* HAVE_PCI_MMAP */
 
 static long proc_bus_pci_ioctl(struct file *file, unsigned int cmd,
                               unsigned long arg)