]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
net: phy: qcom: qca808x: fill in possible_interfaces
authorRobert Marko <robimarko@gmail.com>
Wed, 28 Feb 2024 17:24:10 +0000 (18:24 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 1 Mar 2024 08:56:39 +0000 (08:56 +0000)
Currently QCA808x driver does not fill the possible_interfaces.
2.5G QCA808x support SGMII and 2500Base-X while 1G model only supports
SGMII, so fill the possible_interfaces accordingly.

Signed-off-by: Robert Marko <robimarko@gmail.com>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/qcom/qca808x.c

index a4c61a8e07c3f9396a95f18d06dc6bf4a9c3c42d..5048304ccc9e858130109733597c113c1338d03c 100644 (file)
@@ -167,6 +167,16 @@ static bool qca808x_is_1g_only(struct phy_device *phydev)
        return !!(QCA808X_PHY_CHIP_TYPE_1G & ret);
 }
 
+static void qca808x_fill_possible_interfaces(struct phy_device *phydev)
+{
+       unsigned long *possible = phydev->possible_interfaces;
+
+       __set_bit(PHY_INTERFACE_MODE_SGMII, possible);
+
+       if (!qca808x_is_1g_only(phydev))
+               __set_bit(PHY_INTERFACE_MODE_2500BASEX, possible);
+}
+
 static int qca808x_probe(struct phy_device *phydev)
 {
        struct device *dev = &phydev->mdio.dev;
@@ -231,6 +241,8 @@ static int qca808x_config_init(struct phy_device *phydev)
                }
        }
 
+       qca808x_fill_possible_interfaces(phydev);
+
        /* Configure adc threshold as 100mv for the link 10M */
        return at803x_debug_reg_mask(phydev, QCA808X_PHY_DEBUG_ADC_THRESHOLD,
                                     QCA808X_ADC_THRESHOLD_MASK,