net: mana: Handle unsupported HWC commands

If any of the HWC commands are not recognized by the
underlying hardware, the hardware returns the response
header status of -1. Log the information using
netdev_info_once to avoid multiple error logs in dmesg.

Signed-off-by: Erni Sri Satya Vennela <ernis@linux.microsoft.com>
Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
Reviewed-by: Shradha Gupta <shradhagupta@linux.microsoft.com>
Reviewed-by: Saurabh Singh Sengar <ssengar@linux.microsoft.com>
Reviewed-by: Dipayaan Roy <dipayanroy@linux.microsoft.com>
Link: https://patch.msgid.link/1750144656-2021-5-git-send-email-ernis@linux.microsoft.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>

diff --git a/drivers/net/ethernet/microsoft/mana/hw_channel.c b/drivers/net/ethernet/microsoft/mana/hw_channel.c
index 3d3677c0d01477d1924ff4f21f602cd33077a8da..650d22654d49969d2cd41e71e607fe4bbf52f3b7 100644 (file)
--- a/drivers/net/ethernet/microsoft/mana/hw_channel.c
+++ b/drivers/net/ethernet/microsoft/mana/hw_channel.c
@@ -891,6 +891,10 @@ int mana_hwc_send_request(struct hw_channel_context *hwc, u32 req_len,
        }
 
        if (ctx->status_code && ctx->status_code != GDMA_STATUS_MORE_ENTRIES) {
+               if (ctx->status_code == GDMA_STATUS_CMD_UNSUPPORTED) {
+                       err = -EOPNOTSUPP;
+                       goto out;
+               }
                if (req_msg->req.msg_type != MANA_QUERY_PHY_STAT)
                        dev_err(hwc->dev, "HWC: Failed hw_channel req: 0x%x\n",
                                ctx->status_code);

diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c
index d7079e05dfb87597588f20db24333373897122d0..5aee7bda1504cdb7786bf30f8e5dbb8140ce9122 100644 (file)
--- a/drivers/net/ethernet/microsoft/mana/mana_en.c
+++ b/drivers/net/ethernet/microsoft/mana/mana_en.c
@@ -847,6 +847,9 @@ static int mana_send_request(struct mana_context *ac, void *in_buf,
        err = mana_gd_send_request(gc, in_len, in_buf, out_len,
                                   out_buf);
        if (err || resp->status) {
+               if (err == -EOPNOTSUPP)
+                       return err;
+
                if (req->req.msg_type != MANA_QUERY_PHY_STAT)
                        dev_err(dev, "Failed to send mana message: %d, 0x%x\n",
                                err, resp->status);
@@ -1252,6 +1255,10 @@ int mana_query_link_cfg(struct mana_port_context *apc)
                                sizeof(resp));
 
        if (err) {
+               if (err == -EOPNOTSUPP) {
+                       netdev_info_once(ndev, "MANA_QUERY_LINK_CONFIG not supported\n");
+                       return err;
+               }
                netdev_err(ndev, "Failed to query link config: %d\n", err);
                return err;
        }
@@ -1294,6 +1301,10 @@ int mana_set_bw_clamp(struct mana_port_context *apc, u32 speed,
                                sizeof(resp));
 
        if (err) {
+               if (err == -EOPNOTSUPP) {
+                       netdev_info_once(ndev, "MANA_SET_BW_CLAMP not supported\n");
+                       return err;
+               }
                netdev_err(ndev, "Failed to set bandwidth clamp for speed %u, err = %d",
                           speed, err);
                return err;

diff --git a/include/net/mana/gdma.h b/include/net/mana/gdma.h
index 6fe6cbcd512dbdbcebec58060e686dbb7aef19f0..92ab85061df00b4a79e8b55b66edffbb9dc7aea7 100644 (file)
--- a/include/net/mana/gdma.h
+++ b/include/net/mana/gdma.h
@@ -10,6 +10,7 @@
 #include "shm_channel.h"
 
 #define GDMA_STATUS_MORE_ENTRIES       0x00000105
+#define GDMA_STATUS_CMD_UNSUPPORTED    0xffffffff
 
 /* Structures labeled with "HW DATA" are exchanged with the hardware. All of
  * them are naturally aligned and hence don't need __packed.