xfs: Use abs_diff instead of XFS_ABSDIFF

We have a central definition for this function since 2023, used by
a number of different parts of the kernel.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Carlos Maiolino <cem@kernel.org>

diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c
index 3d33e17f2e5ce01a528dbe80c23c549e2977da57..7839efe050bfa056d35933ec5c5f8c871bdc7b21 100644 (file)
--- a/fs/xfs/libxfs/xfs_alloc.c
+++ b/fs/xfs/libxfs/xfs_alloc.c
@@ -33,8 +33,6 @@ struct kmem_cache     *xfs_extfree_item_cache;
 
 struct workqueue_struct *xfs_alloc_wq;
 
-#define XFS_ABSDIFF(a,b)       (((a) <= (b)) ? ((b) - (a)) : ((a) - (b)))
-
 #define        XFSA_FIXUP_BNO_OK       1
 #define        XFSA_FIXUP_CNT_OK       2
 
@@ -410,8 +408,8 @@ xfs_alloc_compute_diff(
                if (newbno1 != NULLAGBLOCK && newbno2 != NULLAGBLOCK) {
                        if (newlen1 < newlen2 ||
                            (newlen1 == newlen2 &&
-                            XFS_ABSDIFF(newbno1, wantbno) >
-                            XFS_ABSDIFF(newbno2, wantbno)))
+                            abs_diff(newbno1, wantbno) >
+                            abs_diff(newbno2, wantbno)))
                                newbno1 = newbno2;
                } else if (newbno2 != NULLAGBLOCK)
                        newbno1 = newbno2;
@@ -427,7 +425,7 @@ xfs_alloc_compute_diff(
        } else
                newbno1 = freeend - wantlen;
        *newbnop = newbno1;
-       return newbno1 == NULLAGBLOCK ? 0 : XFS_ABSDIFF(newbno1, wantbno);
+       return newbno1 == NULLAGBLOCK ? 0 : abs_diff(newbno1, wantbno);
 }
 
 /*