]> www.infradead.org Git - users/griffoul/linux.git/commitdiff
arm64: dts: rockchip: Fix Bluetooth interrupts flag on Neardi LBA3368
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Mon, 18 Aug 2025 09:04:47 +0000 (11:04 +0200)
committerHeiko Stuebner <heiko@sntech.de>
Sun, 24 Aug 2025 10:36:20 +0000 (12:36 +0200)
GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
These are simple defines so they could be used in DTS but they will not
have the same meaning: GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE.

Correct the interrupt flags, assuming the author of the code wanted same
logical behavior behind the name "ACTIVE_xxx", this is:
  ACTIVE_HIGH  => IRQ_TYPE_LEVEL_HIGH

Fixes: 7b4a8097e58b ("arm64: dts: rockchip: Add Neardi LBA3368 board")
Cc: stable+noautosel@kernel.org # Needs testing, because actual level is just a guess
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Tested-By: Alex Bee <knaerzche@gmail.com>
Link: https://lore.kernel.org/r/20250818090445.28112-4-krzysztof.kozlowski@linaro.org
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
arch/arm64/boot/dts/rockchip/rk3368-lba3368.dts

index b99bb0a5f9006b288becfd845ecbfefceb5cf854..b9801a691b486cf13d24a8859254666025ec83f5 100644 (file)
 
        bluetooth {
                compatible = "brcm,bcm4345c5";
-               interrupts-extended = <&gpio3 RK_PA7 GPIO_ACTIVE_HIGH>;
+               interrupts-extended = <&gpio3 RK_PA7 IRQ_TYPE_LEVEL_HIGH>;
                interrupt-names = "host-wakeup";
                clocks = <&rk808 RK808_CLKOUT1>;
                clock-names = "lpo";